RE: [Xen-devel] Shouldn't XendDomainInfo.py: _releaseDevices call destroyDevice?

["Petersson, Mats" <Mats.Petersson@xxxxxxx>]

> -----Original Message-----
> From: Keir Fraser [mailto:keir@xxxxxxxxxxxxx] 
> Sent: 16 May 2007 13:34
> To: Petersson, Mats; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] Shouldn't XendDomainInfo.py: 
> _releaseDevices call destroyDevice?
> 
> This is how it looks to me too! Unless Ewan or Tom knows 
> better, this is
> probably worth trying out. It would be a neater solution for 
> the console
> backend cleanup than your hacky patch, if it works.

Yes, particularly since my hacky patch doesn't actually work for all the
cases, which is why I started looking at it again [the xenstore still
grows, but not quite as quickly].   :-(

Now, this brings a question: The _releaseDevices attempts to remove all
devices as one transaction, but calling destroyDevices for each device
would of course make it into multiple transactions. Is there any reason
why this would make it a problem?

--
Mats

> 
>  -- Keir
> 
> On 16/5/07 13:04, "Petersson, Mats" <Mats.Petersson@xxxxxxx> wrote:
> 
> > It seems like something is missing in the _releaseDevices, 
> and I think
> > the correct way to fix it would be to call destroyDevice - 
> is there any
> > reason I shouldn't use that function, rather than the 
> current method of
> > removing (some of) the device info from XenStore in _releaseDevices?
> > 
> > --
> > Mats
> > 
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> 
> 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel