[Xen-devel] [PATCH] [xm] Fix vncdisplay for hvm guests

[Jim Fehlig <jfehlig@xxxxxxxxxx>]

'vncdisplay=N' in hvm config file is ignored when building qemu-dm
arguments.

xm create or xm new -> xm start with hvm config file containing
vnc=1
vncdisplay=5

results in '-vncunused' being passed to qemu-dm.  There are several
approaches
for a fix - this patch defaults vncdisplay to None in xm options.  It
currently defaults to 1 and is always included in the image config
created by configure_hvm() in tools/python/xen/xm/create.py.  In xend
(tools/python/xen/xend/image.py - parseDeviceModelArgs), vncunused takes
precedence over vncdisplay.

This patch is against 3.1.0-testing but looks like problem exists in
unstable as well - even with recent changes to
tools/python/xen/xend/image.py when moving to qemu 0.9.0

Regards,
Jim



# HG changeset patch
# User Jim Fehlig <jfehlig@xxxxxxxxxx>
# Date 1179270277 21600
# Node ID b6a56d49c45c7ae82851e04e6322f18aa6e2c481
# Parent  aee991c7723a0c2fb88811c7c8b3cbdcb89f2bb9
'vncdisplay=N' in hvm config file is ignored when building qemu-dm arguments.

xm create or xm new -> xm start with hvm config file containing
vnc=1
vncdisplay=5

results in '-vncunused' being passed to qemu-dm.  There are several approaches
for a fix - this patch defaults vncdisplay to None in xm options.

Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>

diff -r aee991c7723a -r b6a56d49c45c tools/python/xen/xm/create.py
--- a/tools/python/xen/xm/create.py     Wed May 09 16:34:47 2007 +0100
+++ b/tools/python/xen/xm/create.py     Tue May 15 17:04:37 2007 -0600
@@ -474,7 +474,7 @@ gopts.var('vnclisten', val='',
           use="""Address for VNC server to listen on.""")
 
 gopts.var('vncunused', val='',
-          fn=set_bool, default=1,
+          fn=set_bool, default=None,
           use="""Try to find an unused port for the VNC server.
           Only valid when vnc=1.""")
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel