Re: [Xen-devel] [PATCH] fix: growing kernel commandline

[Florian Kirstein <xenlist@xxxxxxxxxxxxxx>]

Hi,

> I'm actually just about to push a straight backport of the fix which
> went into unstable. If further fixes are required on top of that we
> should consider making them in xen-unstable first.
I agree for anything further than what I've done. But the switching of
ip= and root= parameter in the processing, basically just an exchange of
the two blocks:

arg_ip = sxp.child_value(image_sxp, 'ip')
if arg_ip and not re.search(r'ip=[^ ]+', kernel_args):
   kernel_args = 'ip=%s ' % arg_ip + kernel_args

and:

arg_root = sxp.child_value(image_sxp, 'root')
if arg_root and not re.search(r'root=', kernel_args):
   kernel_args = 'root=%s ' % arg_root + kernel_args

seems to be riskless, if you do this additional to the -unstable patch
we should be on the safe side, I hope :) Otherwise ip= and root= parameter
will change their order on the commandline (because they now prepend
instead of append themselves), and I thought keeping that intact for
bad parsers was the main reason for all of this... That's why I did
this change when backporting the fix.

(:ul8er, r@y

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel