Re: [Xen-devel] [PATCH] inline VMX functions

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 13/11/06 2:35 am, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote:

> inline VMX functions since most of these functions are called just once.
> 
> Signed-off-by: Xin Li <xin.b.li@xxxxxxxxx>

Unless the function call is really hot (in an inner loop for example) I
don't believe that the performance benefit of inlining is measurable (or
maybe even exists at all). Against that there are the disadvantages that
debugging from a backtrace becomes much more of a pain (especially that
vmexit handler, which becomes *really* big!), and there's a tendency for
'inline' to spread around like a 'go faster' magic dust, applied to
functions where it really doesn't help. So I'm moderately inclined not to
take the inlining bits of this patch unless you strongly disagree.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel