[Xen-devel] RE: clear redunadant IRQ disable

["Dong, Eddie" <eddie.dong@xxxxxxxxx>]

Keir Fraser wrote:
> On 31/10/06 08:38, "Dong, Eddie" <eddie.dong@xxxxxxxxx> wrote:
> 
>> Clear the redundant code in vmx_load_cr2 and use got "%EBX" for
>> current vcpu pointer.
> 
> vmx_load_cr2() simplification is worthwhile but I'm not sure about
> 'vcpu *' as a parameter to various functions. It's cheap to compute
> current and it's actually confusing sometimes whether a function
> takes an arbitrary vcpu or whether it is allowed to assume current.
> This is made obvious if the function grabs current for itself.
> 
Fine too. So you will delete the IRQ disable line, right :-)
Eddie

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel