Re: [Xen-devel] [PATCH 10/10][TOOLS][XM-TEST] Fix Memory assumptions in the create tests

[Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>]

On Tue, Oct 24, 2006 at 02:54:16PM +0100, Ewan Mellor wrote:
 
> OK, I've taken the most of the patch, but with the 16MiB low limit left in.

Great.

> What's this bit though (I haven't taken this yet)?

Essentially the XenDomain class does not respect the arch defaults where
as XmTestDomain does.  This part of the patch forces both HVM and
non-HVM tests to use XmTestDomain.  With appropriate changes to the
extraConfig arg.

On PPC we need to use the arch defaults to get the console setup
correctly.

I chose not to include the arch defaults in XenDomain as this gives us
flexibility for the future.
 
> diff -r 69035d8a5f2a -r 2854ceda351e 
> tools/xm-test/tests/create/14_create_blockroot_pos.py
> --- a/tools/xm-test/tests/create/14_create_blockroot_pos.py   Thu Oct 19 
> 17:01:02 2006 +1000
> +++ b/tools/xm-test/tests/create/14_create_blockroot_pos.py   Thu Oct 19 
> 17:02:40 2006 +1000
> @@ -18,17 +18,12 @@ rdpath = getRdPath()
>  #     print "Using %s" % output
>  
>  if ENABLE_HVM_SUPPORT:
> -    domain = XmTestDomain(name="14_create_blockroot")
> +    config = None
>  else:
> -    config = {"memory" : "64",
> -              "root"   : "/dev/hda1",
> -              "name"   : "14_create_blockroot",
> -              "kernel" : getDefaultKernel(),
> +    config = {"root"   : "/dev/hda1",
>                "disk"   : "file:%s/initrd.img,hda1,w" % rdpath
>                }
> -    domConfig = XenConfig()
> -    domConfig.setOpts(config)
> -    domain = XenDomain(name=domConfig.getOpt("name"), config=domConfig)
> +domain = XmTestDomain(name="14_create_blockroot", extraConfig=config)
>  
>  try:
>      console = domain.start()

Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2007.linux.org.au/
   Jan 15-20 2007      The Australian Linux Technical Conference!


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel