Re: [Xen-devel] [PATCH] don't use mlock() with Solaris tools

["Mark Johnson" <johnson.nh@xxxxxxxxx>]

On 10/20/06, Daniel Veillard <veillard@xxxxxxxxxx> wrote:
> On Fri, Oct 20, 2006 at 04:42:47AM +0100, John Levon wrote:
> > on solaris: mlock requires a page aligned address and mlock doesn't ensure 
> the pages won't minor page fault; so don't use it on solaris.
> [...]
> > -/* NB: arr must be mlock'ed */
> > +int lock_pages(void *addr, size_t len)
> > +{
> > +      int e = 0;
> > +#ifndef __sun__
> > +      e = mlock(addr, len);
> > +#endif
> > +      return (e);
> > +}
> > +
> > +void unlock_pages(void *addr, size_t len)
> > +{
> > +#ifndef __sun__
> > +     safe_munlock(addr, len);
> > +#endif
> > +}
> > +
>
>   So on Solaris you don't pin down the memory used for hypercall parameters
> and results at all ? Is there really no risk associated with this strategy ?
>
>   surprised,
We have to pin it down in the privcmd driver. There is no way to
ping the memory from a user app.


MRJ

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel