Re: [Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 17/10/06 11:38 pm, "Mark Williamson" <mark.williamson@xxxxxxxxxxxx>
wrote:

> I've not actually been able to repoduce this problem in test cases with gcc
> 4.0.0, so I assume it's a more recent addition - what's your compiler
> version?

Gcc 4.1.1 definitely has the problem. The strncmp() error I saw was caused
by its definition on Debian 3.1 (latest stable; hardly cutting edge).

> Do you know if the warn_unused_result attribute will override
> the -Wno-unused-value and generate a warning anyhow?  There's probably only a
> few functions we'd want this warning on - if anyone cared about switching
> these warnings off a fairly small patch could anotate the relevant ones.

Warn_unused_result seems to trigger from a totally different code path
that's unaffected by -Wno-unused-value. I definitely think that unused-value
is not as generally useful as unused-{function,label,variable}.
unused-{value,parameter} both have a tendency for false positives.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel