Re: [Xen-devel] skb_checksum_setup and NAT

[Christophe Saout <christophe@xxxxxxxx>]

Am Donnerstag, den 28.09.2006, 18:35 +0100 schrieb Keir Fraser:

> The Linux network stack doesn't expect to be able to receive packets that
> have their protocol-checksum field empty. So we have to add extra packet
> flags to signal this situation. It does create something of a mess unless
> all parts of the network stack know what's going on. I heard that the
> networking maintainers were working on a more generic scheme that we should
> be able to make use of. Apart from that, the stack needs to make sure that
> the proto_csum_blank field is cleared whenever it fills in the full
> checksum.

Ok, ip_forward e.g. sets ip_summed to CHECKSUM_NONE, so it indeed
assumes the checksum is correctly set. This should probably just be
changed accordingly to set CHECKSUM_HW when the incoming packet didn't
have a valid checksum set (although the packet was accepted), possibly
by adding a new CHECKSUM_xxx define.

You are probably talking about the work by Patrick McHardy that is being
merged for post-2.6.18: 

http://www.kernel.org/git/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git&a=search&h=HEAD&s=checksum

It looks promising though it doesn't seem to address this problem in
particular (?).

> For now, if it causes you problems and you just want stuff to work, you can
> run ethtool on your interface in domU: 'ethtool -K eth0 tx off'.

I just ifdef'ed all places where the NAT code changed the checksum. I'm
having a lot of network traffic between DomU's and I'd like to keep CPU
usage down. If someone is interested in the patch, it's attached (just
the FTP NAT part tested though).

Attachment: xen-nat-more-hacking.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel