Re: [Xen-devel] Broken (and unnecessary) SMP locking in blktap.c

["Andrew Warfield" <andrew.warfield@xxxxxxxxxxxx>]

> The *only* reason it might be needed is to provide locking for some
> hypothetical future use of req_increase() and req_decrease(), which
> would need to be locked against each other.  Given that this isn't done
> right now, I suggest we nuke both the locking and the (unused)
> req_decrease function; that can easily be resurrected with correct
> locking if we want it in the future.
>
> Anyone mind if that function dies?
Not at all -- req_decrease is generally broken, and removing it and
the locking seem like a very good plan.  thanks.

a.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel