[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] [XEND] tweak XendDomainInfo to allow architectures to subclass
On 22 Sep 2006, at 21:02, Hollis Blanchard wrote: Hi, thanks for checking in the earlier patch, Alistair. Do you have anycomments on this one?It looks like the "import arch" statement isn't needed, at least, sincethere's a (stranger) import statement for it later. Stranger because it is an absolute import rather than a relative one, which is a good thing. :) The patch looks OK and the impact is pretty low since the impact is only contained within XendDomainInfo.py. domainTypes should probably be renamed to _domainTypes just to make it explicit it is not to be accessed outside of this module. Also, type is a built-in python function, better to rename that to something else, just in case. Cheers, Alastair _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |