Re: [Xen-devel] [PATCH] Sysfs Interface for balloon driver

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Wed, Sep 20, 2006 at 09:26:43AM +0900, Satoshi Uchida wrote:

>     [root@Dom0 ~]# cat /sys/bus/xen/drivers/balloon/statistics/balloon_high
>           0 kB

It's very unusual to have units in a sysfs node. I believe this should
just be the number, and documented elsewhere what the units are.

I also don't quite get the location. I don't quite think of balloon as a
real "driver" as such, it's core kernel functionality rather. Wouldn't
/sys/hypervisor/properties/balloon/ be a more sensible place?

regards,
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel