[Xen-devel] Re: [PATCH] allow connecting to xenconsole from remote hosts

[Muli Ben-Yehuda <muli@xxxxxxxxxx>]

On Thu, Sep 14, 2006 at 03:26:46PM +0100, Keir Fraser wrote:

> On 14/9/06 12:14, "Muli Ben-Yehuda" <muli@xxxxxxxxxx> wrote:
> 
> > Changes since last version:
> > - get rid of the 'queue of messages', instead each queueu is a ring
> >   buffer of characters that we read into and write from directly.
> 
> All our other ring buffers have free-running indexes (i.e., they do not wrap
> to zero when they reach the end of the buffer). This makes it easier to
> determine number of entries in use (it's 'producer minus consumer' -- that's
> another thing, it's standard idiom for us to call the indexes producer (or
> prod) and consumer (or cons)). We then mask the high-order bits when
> actually indexing into the buffer.

Ok, I'll make these changes. Appreciate the feedback!

Cheers,
Muli

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel