Re: [Xen-devel] [PATCH] Paravirt framebuffer console cleanups [5/5]

[Steven Smith <sos22-xen@xxxxxxxxxxxxx>]

> > > > This whole passage is a little peculiar, in that you're only going to
> > > > do anything if use_graphics is disabled.  I'd expect that just leaving
> > > > the current behaviour alone would be the correct thing to do in that
> > > > case.
> > > > 
> > > > Also, why do you need to set CON_CONSDEV at all?
> > > Otherwise, you don't get kernel console messages.
> > Why not?  None of the other console drivers seem to need to set it
> > explicitly, and it seems like it would break setting console=blah on
> > the kernel command line.
> Nothing else sets it explicitly because it happens implicitly in the
> console registration code for the first thing registered with
> register_console().  Alternately, if you have a console=, then
> register_console ensures that your console device has CON_CONSDEV set.
> kernel/printk.c if you want to read all the gory details
The intent of this code seems to be to make sure that CON_CONSDEV is
definitely set on xenconsole if use_graphics is not set, yes?  But as
far as I can see, if use_graphics is not set, xenfb should never call
register_console(), and so this is all redundant.

What am I missing?

Steven.

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel