Re: [Xen-devel] Re: [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c

[Harry Butterworth <harry@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, 2006-08-30 at 13:20 -0500, David F Barrera wrote:
> Harry Butterworth wrote:
> > This patch should fix your problem here.  I have not tested it.  Please
> > give it a go and report whether it is OK to be committed to the tree.
> >
> > The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the
> > sentinel needs to be a 64 bit null pointer for the code to be correct.
> >
> > Signed-off-by: Harry Butterworth <butterwo@xxxxxxxxxx>
> >   
> > ------------------------------------------------------------------------
> >
> > diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c
> > --- a/tools/ioemu/vnc.c     Wed Aug 30 10:05:00 2006
> > +++ b/tools/ioemu/vnc.c     Wed Aug 30 16:23:38 2006
> > @@ -1269,7 +1269,7 @@
> >     exit(1);
> >  
> >      case 0:        /* child */
> > -   execlp("vncviewer", "vncviewer", s, 0);
> > +   execlp("vncviewer", "vncviewer", s, (char *)NULL);
> >     fprintf(stderr, "vncviewer execlp failed\n");
> >     exit(1);
> >  
> >   
> Here's the tail end of what I get:
> 
> ...
> XK_Control_LÃ undeclared (first use in this function)
> /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:847: 
> error: ÃXK_Alt_LÃ undeclared (first use in this function)
> /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: 
> error: ÃXK_1Ã undeclared (first use in this function)
> /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: 
> error: ÃXK_9Ã undeclared (first use in this function)
> make[4]: *** [vnc.o] Error 1
> make[4]: Leaving directory 
> `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/i386-dm'
> make[3]: *** [subdir-i386-dm] Error 2
> make[3]: Leaving directory 
> `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu'
> make[2]: *** [ioemuinstall] Error 2
> make[2]: Leaving directory 
> `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
> make[1]: *** [install] Error 2
> make[1]: Leaving directory 
> `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
> make: *** [install-tools] Error 2

Well, my patch seems to have fixed your previous compile error so I
think it is good.  The errors above are unrelated to the patch.

The errors above indicate that the symbols XK_Alt_L XK_1 and XK_9 are
undefined.  (I don't understand where the weird 'Ã' characters are
coming from in the error report above).

These symbols should be defined in /usr/include/X11/keysymdef.h which is
included by vnc.c.

Please check that you have this header file installed on your build
machine and that the symbols are defined in it.

Harry.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel