[Xen-devel] Re: [Patch][RFC] fix xc_ptrace_core for gdbserver-xen on?x86_64.

[Horms <horms@xxxxxxxxxxxx>]

On Fri, 25 Aug 2006 12:22:21 +0900, Akio Takebe wrote:
> [-- text/plain, encoding 7bit, charset: iso-2022-jp, 199 lines --]
> [-- Description: Mail message body --]
> 
> Hi, x86_64 people
> 
> I make a patch to fix xc_ptrace_core for gdbserver-xen on x86_64.
> But I'm not familiar with x86_64.
> Please review it.

Hi Takebe-san,

It seems generaly consistent with the i386 code, and looks generaly
fine, though I am not an expert on x86_64 either.

There seem to be three distinct portions of your patch.

1. Make nr_pages an unsigned long instead of a long

   This seems like it should be a separate patch as its really
   a trivial (but probably important) bugfix. Right?

2. Fill in map_domain_va_core() for x86_64

3. Get rid of m2p_array.

   I'm not sure what the relationship between 2 and 3 is.
   Is m2p_array no longer needed because of the changes in 2?
   Or is it a separate cleanup?

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel