Re: [Xen-devel] [PATCH][vTPM] 3/3: TPM device model for qemu dm

["Christian Limpach" <christian.limpach@xxxxxxxxx>]

On 8/21/06, Stefan Berger <stefanb@xxxxxxxxxx> wrote:
> This patch adds a TPM device model to the qemu dm for fully virtualized
> VMs. It is enabled in the VM only if the user requests a TPM device in
> the vm configuration file using the 'vtpm=[...]' line. It enables the
> qemu device model command line with a 'vtpm_instance <instance number>'
> parameter.
Isn't the vtpm instance stored in xenstore anyway?  If so, then please
add code to ioemu's xenstore.c to read it from there instead of adding
a command line switch.  We're moving away from command line switches
for device configuration.

Minor nitpicks:
- don't use extern to access global variables, add them to vl.h instead.
- add tpm.c to VL_OBJS on a separate line, makes merging it much easier.

   christian

> Signed-off-by: David Safford <safford@xxxxxxxxxxxxxx>
> Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel