Re: [Xen-devel] [PATCH][XEN]xm dump command add on

[Ken Hironaka <hironaka.ken@xxxxxxxxxxxxxxxx>]

John, comment are enclosed.

On Mon, 2006-08-14 at 15:50 +0100, John Levon wrote:
> On Mon, Aug 14, 2006 at 05:03:59PM +0900, Ken Hironaka wrote:
> 
> > +        if((sts=copy_from_domain_page(xc_handle, domid,
page_array[i], dump_mem))<0)
> > +            cpy_sts=sts;
> > +
> > +    if(cpy_sts!=0)
> > +        goto error_out;
> 
> Should be:
> 
>       if ( ... )
> 
> > +        try:
> > +            log.info("Dumping Core for Domain %s (%d).",
dominfo.getName(),
> > +                     dominfo.getDomid())
> 

I must note, this section is in C code and not Python, as it is part of
xc_dumpcore() in libxc. I understand that it is better to log the error
as soon as possible, but logging takes place at the Python layer above.

> Better as "Domain core dump requested for domain %s (%d)" ?
> 
> > +    if not live:
> > +        print "pausing domain:%s ..." % str(dom)
> > +        server.xend.domain.pause(dom)
> 
> Is it really worth mentioning the pause? It doesn't take any amount of
> time, surely.
Yes, I do think that is is necessary to mention a pause. There are times
when the user will send an Interrupt with say, CTRL+C at the middle of
dumping. Of course, xm dump will terminate, but the domU will continue
to be paused and it will have to be unpaused manually. Of course, if you
read the inner workings I wrote you would understand, but I think it
will save a lot of people time wondering why their domain froze.

> regards
> john

best regards,
Ken



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel