Re: [Xen-devel] [PATCH][TOOLS] allow the selection of blktap and firmware thru config files

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

On Aug 11, 2006, at 7:03 AM, Christian Limpach wrote:

> On 8/10/06, Jeremy Katz <katzj@xxxxxxxxxx> wrote:
> > On Thu, 2006-08-10 at 14:51 +0100, Julian Chesterfield wrote:
> > > Because libaio is often not included in the distro. In order to  
> > avoid
> > > breaking the build we either had to include checks in the  
> > Makefile for
> > > the existence of the library and build if necessary, or just  
> > statically
> > > build within the tree. We chose the latter since it was the  
> > cleanest
> > > approach.
> >
> > Except that for distributions, if there's a bugfix which needs to be
> > applied to libaio, it now needs to go to two different places.   
> > This is
> > a path that is all but guaranteed to be a headache for distros in the
> > future :(
> Yes that's valid.  How about we add the proposed config option and set
> its default from a test whether the required files exist?
hmm.. thinking about the test:
  for i in "/usr/lib/libaio.so.*"; do
    if [ -r /usr/lib/libaio.so ] ; then
      echo "please install libaio developer package, you are on  
debian please add the symlink"
      return fail
    else
      echo "using system provided library"
      return success
    fi
  done
  echo "please add libaio developer package"
  return fail

and now tools/libaio "disappears in a poof of logic" :)
no config option necessary.

Perhaps a handy build tools checker that makes sure that all  
everything you need to build and/or run is there.
we already check the version of python.

-JX



                

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel