[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the generic header.
On Aug 8, 2006, at 8:26 AM, Keir Fraser wrote: On 8/8/06 12:49 pm, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote:I have a linker problem building this file in POWERPC as you may suspect. The ./driver/xen/ file is more like the other archs than x86, and should be more portable. Not sure what header magik would be needed here, if you think its worthwhile I'll pursue it.You could switch the call order in drivers/xen/core/reboot.c so thatmachine_emergency_restart calls machine_restart, and then conditionallycompile the former only for x86. Not super nice but it's at least straightforward. I'd take a patch that did that. hmm, there are a lot of x86 isms in this file.. I think having all these ifdefs in ./drivers will be problematic to the Linux integration cause. At some point I could see us trying to remove/abstract them anyway.Perhaps we could prefix all the methods with "xen_" and have arch specific code _in_ arch specific directories call it accordingly? I would also like to separate the suspend code from the reboot/halt code into different files since thats is cleaner to select that support by CONFIG_, thoughts? -JX _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |