Re: [Xen-devel] [PATCH 0/6] xen,xend,tools: Add NUMA support to Xen

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Lundi 31 Juillet 2006 21:09, Ryan Harper a écrit :
> I've respun the NUMA patches against 10874 and I'm re-submitting them
> with the optimizations mentioned [1]previously on the list.  There was a
> request to see the overhead on non-numa/single-node machines.  I've
> re-run those benchmarks (ballooning up from small mem to multi-gig) as
> well as timing the initially domain increase_reservation time to gauge
> the overhead when allocating from the heap.
Hi,

one more comment:
in dom0_ops.c:
+    case DOM0_AVAILHEAP:
+    {
+        ret = -EINVAL;
+        if ( op->u.availheap.node >= num_online_nodes() )
+            break;
+        if ( op->u.availheap.zone >= NR_ZONES )
+            break;
+
+        /* indicate the number of zones/nodes queried.
+         * NB: -1 is wild card for all zones/nodes */
+        ( op->u.availheap.zone < 0 ) ?
+            (op->u.availheap.nr_zones=NR_ZONES) :
+            (op->u.availheap.nr_zones=1);
+
+        ( op->u.availheap.node < 0 ) ?
+            (op->u.availheap.nr_nodes=num_online_nodes()) :
+            (op->u.availheap.nr_nodes=1);

I am not sure this corresponds to the Xen style.
Either use an if statement or a variable assignment:
op->u.availheap.nr_nodes = ( op->u.availheap.node < 0 ?)  num_online_nodes() : 
1;

Tristan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel