[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Add lost logic for VGA initialization


  • To: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
  • From: "Christian Limpach" <christian.limpach@xxxxxxxxx>
  • Date: Thu, 27 Jul 2006 11:12:42 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 27 Jul 2006 03:13:05 -0700
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=T6ao/iCaYm4Q1FfaRy5aeZQkO2Rex1YmXCToFjhyCnvVyBQYNlOSXO3d6TiKX2T4AnPgbqNyLhqe0y3fM7jfKyFtD3HIzJ0VuDZ/sOjLBc9Mdjzj3arVPMfwN9iuQIDASk4xAriyaCf0zgZkczIR3SMyOjvB/Ig+bFYk/U58dg4=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 7/27/06, Zhang, Xiantao <xiantao.zhang@xxxxxxxxx> wrote:
Hi, Christian
        Thank you for your comments. But I check the patch on tip. Seems the 
following line not in upstream. I don't know why this part was lost when 
check-in.
diff -r 254c090854de tools/ioemu/hw/vga.c
--- a/tools/ioemu/hw/vga.c      Wed Jul 26 15:59:36 2006 -0600
+++ b/tools/ioemu/hw/vga.c      Thu Jul 27 09:27:03 2006 +0800
@@ -1953,6 +1953,7 @@ void vga_common_init(VGAState *s, Displa
                          vga_screen_dump, s);
     /* XXX: currently needed for display */
     vga_state = s;
+    vga_bios_init(s);
 }

Applied, I hope we've got it all now :-)

   christian

Thanks & Best Regards
-Xiantao

OTC,Intel Corporation

> -----Original Message-----
> From: Christian Limpach [mailto:christian.limpach@xxxxxxxxx]
> Sent: 2006年7月26日 22:23
> To: Zhang, Xiantao
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH] Add lost logic for VGA initialization
>
> On 7/26/06, Zhang, Xiantao <xiantao.zhang@xxxxxxxxx> wrote:
> > This patch adds lost logic for vga initialization. It was lost after
> > changing to new Qemu.
> > Signed-off-by : Kevin Tian <kevin.tian@xxxxxxxxx>
> > Signed-off-by : Zhang Xiantao <xiantao.zhang@xxxxxxxxx>
>
> I've applied this -- it would be nice if you could cleanup the code
> some more to use arrays to initialize s->sr[], s->gr[], s->ar[] and
> s->cr[].  Thanks!
>
>     christian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.