[Xen-devel] Re: [RFC PATCH 23/33] subarch TLB support

[Chris Wright <chrisw@xxxxxxxxxxxx>]

* David Miller (davem@xxxxxxxxxxxxx) wrote:
> From: Chris Wright <chrisw@xxxxxxxxxxxx>
> Date: Tue, 18 Jul 2006 00:00:23 -0700
> 
> > +        BUG_ON(HYPERVISOR_mmuext_op(&op, 1, NULL, DOMID_SELF) < 0);
> 
> Although it happens to work currently, I think we should get out of
> the habit of putting operations with wanted side effects into BUG_ON()
> calls.  The following is therefore more preferable:
> 
>       ret = HYPERVISOR_mmuext_op(&op, 1, NULL, DOMID_SELF);
>       BUG_ON(ret < 0);
> 
> If this were ASSERT() in userspace, turning off debugging at build
> time would make the evaluations inside of the macro never occur.  It
> is my opinion that BUG_ON() should behave similarly.

Good point, I'll clean those up.

thanks,
-chris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel