Re: [Xen-devel] [PATCH] Improve xenbus timeout error message

[Mark McLoughlin <markmc@xxxxxxxxxx>]

On Fri, 2006-06-30 at 17:57 +0100, Keir Fraser wrote:
> On 30 Jun 2006, at 17:52, Mark McLoughlin wrote:
> 
> >> The obvious thing to do here is work out which devices haven't been
> >> picked up by any driver, and not wait on those since they are 
> >> obviously
> >> not going to connect! We should either silently ignore those, or maybe
> >> print a list of them for information.
> >
> >     Good point, how about this patch then?
> 
> Yes, I just checked in a patch rather similar, except I also print the 
> driverless devices (could be handy for diagnostics, but I'm not sure if 
> it might turn out to be too noisy in some situations) and move some 
> functions closer to where they are used.
> 
> Your original path is changeset 10570 in xen-unstable; my modification 
> is 10573. Should be in the public tree in a couple of hours.

        Note, the original patch leaked device references when printing out the
warning if there are multiple disconnected devices. Fixed in the second
patch.

Cheers,
Mark.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel