[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] Re: [PATCH]: kexec: framework and i386 (Take IX)
On 17 May 2006, at 10:52, Horms wrote: as promised earlier in the day, here is an update on the kexec/kdump patch. The main changes are that SMP now works, and the dumping of cpu registers for kdump has been moved into the hypervisor so as to allow all CPUs to be captured, not just dom0's VCPUs. Just looking at the generic patch: * Define KEXEC_CMD_* in your public kexec.h header, not xen.h.* Don't pack all the different arg structs into a union -- the union will change in size if you ever add a bigger argument substructure, plus it's ugly. Split them out and put a comment by each KEXEC_CMD_* definition explaining what its argument parameter points at (see other header files like vcpu.h for an example). * Can you explain the need for all the changesin your kexec.patch? I guess there are some virt_to_phys address translations that need fixing up, but you also scatter a few hypercalls around in there (e.g., in base/cpu.c) -- can they not be handled more cleanly, or is kexec-on-xen somehow more special than kexec on any native architecture? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |