Re: [Xen-devel] [PATCH] Fix checksum errors when firewalling in domU

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 10 May 2006, at 15:51, James Dykman wrote:

> Right, that was hiding more brokenness. Fixed below.
>
> Signed-off-by: Jim Dykman <dykman@xxxxxxxxxx>
> Fix checksum errors when firewalling in domU
Two more questions:
 1. Why do you need to check proto_csum_blank in the start_xmit() 
handling paths of netfront and netback? skb_checksum_setup() will have 
set ip_summed=CHECKSUM_HW in all cases won't it?
 2. The change to not aggressively clear proto_csum_blank appears to 
make sense. However, why not clear it inside skb_checksum_help(), 
rather than modifying two of its callers to do so? Because it'll be in 
one place we can wrap in ifdef XEN rather than needing to add yet 
another wrapper function to do the clearing.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel