Re: [Xen-devel] [PATCH] pci-dma-xen.c change necessary for xen/ia64

[Muli Ben-Yehuda <muli@xxxxxxxxxx>]

On Tue, Apr 25, 2006 at 01:30:52PM +0900, Isaku Yamahata wrote:
> 
> xenLinux/ia64 with dom0 vp model uses
> linux-2.6-xen-sparse/arch/i386/kernel/pci-dma-xen.c.

Err, why?

> But it has its own dma_map_page(), dma_declare_coheremnt_memory() and their
> families. So those in pci-dma-xen.c are unnecessary. #ifdef out
> them.

Won't it be cleaner for IA64 to have a DMA API implementation for each
different mode of operation? if code can be consolidated between
different implementations it should be put in a common file, under
arch/ia64 or in lib/ or drivers/, depending on the usage. The #ifdef
approach (not to mention using one arch's files from another) #is
going to be severely frowned upon upstream.

Cheers,
Muli


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel