Re: [Xen-devel] [PATCH] assign_irq_vector adjustments

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 13 Apr 2006, at 15:59, Jan Beulich wrote:

> In both i386 and x86-64 Linux, using a static variable (and thus 
> having the potential of missing synchronization there,
> as I suspect exists in native Linux) is not needed with the hypercall 
> approach. In the hypervisor, the patch adds the
> needed synchronization.
1. Should you not assign to irq_vector[] and vector_irq[] in Xen with 
the lock held? Otherwise you may double-allocate if two requests are 
made concurrently to assign for the same irq (unlikely, but...)
2. Since that'll need a re-send, please also add a Signed-off-by line.

 Thanks,
 Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel