Re: [Xen-devel] Patch to xm create search domU config in /etc/xen/auto

[Anthony Liguori <aliguori@xxxxxxxxxx>]

Hope this doesn't appear to be singling you out, but this is a good 
opportunity to highlight some patch submitting good practices:
1) Your patch doesn't contain a Signed-off-by line so it cannot be applied.

2) Your patch is attached with an improper MIME type.  If you cannot use 
a more sane mailer, you should also inline your patches (it's impossible 
for me to actually comment on your patch in a note without some nasty 
copy-paste stuff).
3) You include no explanation of why your patch is needed.  It seems 
somewhat arbitrary to add /etc/xen/auto to the default search path.  Why 
do you need this and why do you think other people would need this?
4) Your patch is based at a weird location (within tools/).  It's 
usually best to patch at the top of the repository (diff -u 
a/tools/xen/xm/create.py b/tools/....).  Actually, if you just use hg 
export, it'll do the right thing for you.
Please resubmit with the appropriate corrections.

Thanks!

Regards,

Anthony Liguori

Itamar Reis Peixoto wrote:
> attached.
>  
> ------------------------------------------------------------------------
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>   

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel