[Xen-devel] Re: [PATCH] xm: cleanup sched-sedf and tests

[Ryan Harper <ryanh@xxxxxxxxxx>]

* Ewan Mellor <ewan@xxxxxxxxxxxxx> [2006-03-11 08:56]:
> On Fri, Mar 10, 2006 at 02:06:40PM -0600, Ryan Harper wrote:
> 
> > - Reworked to use your match_domid suggestion and filtering
> > - Aligned output and help to fit within 80 char limit
> > - User now deals in milliseconds instead of nanoseconds
> > - Fixed some missing parens in tests (I had pushed stale versions)
> > - Updated tests to deal with period/slice/latency in ms
> > 
> > root@bebop:~/xm-test.sedf/tests/sedf # xm sched-sedf
> > Name                              ID Period(ms) Slice(ms) Lat(ms) Extra 
> > Weight
> > Domain-0                           0      20.0      15.0     0.0      1     
> >  0
> > 
> > -- 
> > Ryan Harper
> > Software Engineer; Linux Technology Center
> > IBM Corp., Austin, Tx
> > (512) 838-9253   T/L: 678-9253
> > ryanh@xxxxxxxxxx
> > 
> > 
> > diffstat output:
> >  python/xen/xm/main.py                               |  107 
> > +++++++++-----------
> >  xm-test/tests/sedf/01_sedf_period_slice_pos.py      |    8 -
> >  xm-test/tests/sedf/02_sedf_period_lower_neg.py      |    5 
> >  xm-test/tests/sedf/03_sedf_slice_lower_neg.py       |    5 
> >  xm-test/tests/sedf/04_sedf_slice_upper_neg.py       |    5 
> >  xm-test/tests/sedf/05_sedf_extratime_pos.py         |    2 
> >  xm-test/tests/sedf/06_sedf_extratime_disable_neg.py |    3 
> >  7 files changed, 73 insertions(+), 62 deletions(-)
> > 
> > Signed-off-by: Ryan Harper <ryanh@xxxxxxxxxx>
> 
> Applied, thanks.
> 
> It would make my life a little easier if you would (preferably) use "hg 
> export"
> to create your patches and (definitely) attach your patches to your email as
> a separate attachment, as opposed to including them inline in the body of the
> email.  Patches tend to get mangled if you include them inline, as they get
> word-wrapped, and using hg export means that the commit comment gets inserted
> automatically, rather than me having to cut-and-paste that separately.

I'll be sure to use hg export.  I thought that inline was preferred rather
than attachment so that the patch is readable directly in the mail client.
Ideally, the patch shouldn't word-wrap.  I can make them attachments if
that is the preferred method.

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@xxxxxxxxxx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel