[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] linux: allow pciback to be built as a module
>> >> - pcibios_set_master(dev); >> >> + pci_set_master(dev); >> > >> >There's probably not any problem here, but most of pci_set_master is >> >already done in the frontend (when the frontend device driver calls >> >pci_set_master), I was trying to avoid duplicating the effects of >> >pci_set_master here by using pcibios_set_master instead. >> >> The main reason for these changes is that only pci_* are exported, not >> pcibios_*. >> > >I think the only place where there could potentially be an issue is >changing pcibios_enable_device to pci_enable_device. pci_enable_device >calls pci_fixup_device which *may* have some side effects that a >non-linux driver domain may not expect or want. Maybe you could call >pci_enable_device_bars (which is exported) just like it's called in >pci_enable_device to skip the pci_fixup_device method. I'm not certain about that - pci_fixup_device is called in a number of other places (with different stage arguments), most notably in pci_init for *all* devices, and hence not calling it here might result in inconsistencies. I would want to either suppress all of the calls for a device handled outside dom0, or none. Since suppressing all (or reverting possible previous adjustments) is going to be at least difficult, I think letting the call happen here is better. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |