[Xen-devel] [PATCH] xc_core.c - Fix order of evaluation issue in xc_domain_dumpcore

[Ben Thomas <bthomas@xxxxxxxxxxxxxxx>]

Fix order-of-evaluation issue in xc_domain_dumpcore.  The intent is
to move blocks of memory 4096 pages at a time, and a buffer is
allocated for this.  Unfortunately, the #define is without
parentheses and %/* are the same order and evaluated left to right.
Result: very big buffer being used 4 pages at a time.  Luckily,
the fix is simple.

Signed-off-by: Ben Thomas (bthomas@xxxxxxxxxxxxxxx)

--
------------------------------------------------------------------------
Ben Thomas                                         Virtual Iron Software
bthomas@xxxxxxxxxxxxxxx                            Tower 1, Floor 2
978-849-1214                                       900 Chelmsford Street
                                                   Lowell, MA 01851

diff -r 96678f701d42 tools/libxc/xc_core.c
--- a/tools/libxc/xc_core.c     Mon Mar  6 11:12:48 2006 -0500
+++ b/tools/libxc/xc_core.c     Wed Mar  8 20:36:21 2006 -0500
@@ -6,7 +6,7 @@
 #include <zlib.h>
 
 /* number of pages to write at a time */
-#define DUMP_INCREMENT 4 * 1024
+#define DUMP_INCREMENT (4 * 1024)
 #define round_pgup(_p)    (((_p)+(PAGE_SIZE-1))&PAGE_MASK)
 
 static int

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel