Re: [Xen-devel] [PATCH] Repost - xm lists display and formatting

[Woody Marvel <marvel@xxxxxxxxxx>]

Stefan

Thanks Stephan.

On Fri, 2006-02-17 at 17:03 -0500, Stefan Berger wrote:
> 
> xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 02/17/2006 02:54:21 PM:
> 
> > Stefan
> > Hi
> > Thanks for the xm-text initiative.
> > 
> > Did you test with xm-test (the whole suite of testx) on i386 and/or
> > x86_64 and/or VMX, before submitting the patches? Did they all work?
> >  
> 
> 
> Here's now the output of a testrun on x86: 
> 
> REASON: (7 nics) Console didn't respond: probably crashed!
> FAIL: 13_create_multinic_pos.test
> REASON: ping loopback failed for size 65507. ping eth0 failed for size
> 65507.
> XFAIL: 02_network_local_ping_pos.test
> REASON: Ping to dom0 failed for size 32767 65507.
> XFAIL: 05_network_dom0_ping_pos.test
> REASON: Ping failed for size 32767 65507.
> XFAIL: 11_network_domU_ping_pos.test
> REASON: /proc/cpuinfo says xend didn't enforce dom0_cpus (2 != 1)
> FAIL: 01_enforce_dom0_cpus_basic_pos.test
> REASON: xm migrate returned invalid 256 != 0
> FAIL: 01_migrate_localhost_pos.test
> 
> I think none of these errors is related to the xm changes regarding
> network-list or block-list. 
> I expect the consequences of the xm changes NOT to influence the test
> results on x86_64 or VMX - other challenges might be lurking there. 
> 
>    Stefan
> 
> > Dan is right, the doc also needs work. 
> 
> 
> > 
> > woody
> > ==============
> > On Fri, 2006-02-17 at 11:00 -0800, Daniel Stekloff wrote:
> > > On Fri, 2006-02-17 at 10:41 -0800, Ewan Mellor wrote:
> > > > On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger wrote:
> > > > 
> > > > > This patch displays the network-list/block-list/vtpm-list
> using the 'xm'
> > > > > command. It supports the '--long' option.
> > > > > 
> > > > > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
> > > > 
> > > > Applied, thank you.
> > > > 
> > > > This will break xm-test.  Does anyone fancy fixing it up?  The
> > > > least-effort thing to do is change all of the calls to
> block-list and
> > > > network-list to become block-list --long and network-list
> --long, but
> > > > it would be better if we fixed the eyecatchers (where necessary)
> to work
> > > > with the new, formatted commands, and maybe added a few tests
> for
> > > > xyz-list --long as well.
> > > > 
> > > > And of course it would be nice to have tests for vtpm-list 
> > (after detecting
> > > > the presence of appropriate hardware, I guess).
> > > > 
> > > > Any volunteers?
> > > 
> > > 
> > > Hi,
> > > 
> > > Three comments:
> > > 
> > > 1) Changes like those introduced by this patch should be submitted
> with
> > > corresponding tests in xm-test. We want to continue to use xm-test
> to
> > > verify functionality.
> > > 
> > > 2) The documentation - like man pages - should be updated along
> with the
> > > new functionality. 
> > > 
> > > 3) xm-test should be used to verify patches prior to submitting
> and
> > > applying. 
> > > 
> > > Thanks,
> > > 
> > > Dan
> > > 
> > > 
> > > _______________________________________________
> > > Xen-devel mailing list
> > > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > > http://lists.xensource.com/xen-devel
> > > 
> > -- 
> > Sincerely,      Woody Marvel
> > IBM Linux Technology Center
> > Open Source Virtualization
> > email: marvel@xxxxxxxxxx
> > 503-578-3833   Beaverton, OR 97006
> > **********************************
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
-- 
Sincerely,      Woody Marvel
IBM Linux Technology Center
Open Source Virtualization
email: marvel@xxxxxxxxxx
503-578-3833   Beaverton, OR 97006
**********************************


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel