[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] avoid NULL pointer dereference.
On 24 Nov 2005, at 04:48, Tony Breeds wrote: Hi All, xen/common/acm_ops.c, check for a NULL pointer and then cheerfully dereferences it. Signed-off-by: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx> Applied, but nearby code goto's out so I changed the patch to do that.In fact there seems to be no convention in that function as to whether returning immediately or goto'ing out (and doing dome return-code cooking) is the right thing to do. Should all the returns be goto out's? If there is an important distinction then a comment describing it ought to be added. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |