Re: [Xen-devel] [PATCH] fast_flush_area in blkback.c still broken after 55194bd55b86

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 7 Nov 2005, at 11:19, harry wrote:

> I think you need this patch otherwise you will be passing uninitialised
> data from the stack to GNTTABOP_unmap_grant_ref in fast_flush_area.
>
> Also, I think the memset of the pending_grant_handles array should
> happen before you start using them so I moved it to before
> blkif_xenbus_init.  I'm not sure if this is necessary or it might
> possibly have to go even earlier.
Two good catches. In fact the initialisation of pending_grant_handles 
was more seriously broken -- the use of memset was bogus since the 
array elements are u16's not u8's. So only half the array was being 
initialised, and high byte of the initialiser value was discarded. 
Where do we find these programmers.... :-)
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel