[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: [PATCH] [VT]long event-channel pending and mask arrays



Keir,
 You are right. It can be changed to long but it is not necessary.

The issue in SMP dom0 for x86_64 got introduced before your SMP code
restructuring (merge smpboot.c) rev 7415. 

The rev 7412 has my fix for SMP dom0/domU. I have tested that fix here
which was working fine. That patch is pulled in the tree with many other
patches on the same day. With your 7402 patch (long masks) it is
breaking SMP dom0 differently. If I checkout the 7412 and then revert
the 7402 from it the SMP dom0 works fine. I can try reverting the 7402
changes from the latest tip to see what happens to SMP. Do you have any
better ideas?

>
>sync_const_test_bit does not need to change. Note it casts the bitmap
>pointer to 'int' which is 32-bit quantity even on x86/64. So we do want
>to divide the offset by 32, not BITS_PER_LONG.
>
>  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.