[Xen-devel] Re: [PATCH] network-bridge script support for multiple external interfaces

[Charles Duffy <cduffy@xxxxxxxxxxx>]

David Hopwood wrote:
> Charles Duffy wrote:
> >  # antispoof  Whether to use iptables to prevent spoofing (default yes).
> [...]
> >  antispoof=${antispoof:-no}
> The antispoof default is not consistent with the comment.
Quite so. (That's original behavior, though, and so any fix for it 
should be checked in as a separate changeset -- from my 
revision-control-nazi days I still have a strong preference for keeping 
different fixes in different changesets so that they can be merged, 
accepted or rejected, and otherwise handled individually).

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel