Re: [Xen-devel] [PATCH] tools: Fix network-bridge to work with Gentoo (version 2)

[Jeremy Katz <katzj@xxxxxxxxxx>]

On Tue, 2005-10-04 at 18:54 -0500, Jon Mason wrote:
> This patch fixes domU networking in Gentoo.  The change to ifup/ifdown
> (which isn't availabe in Gentoo) prevents the bridge from being setup
> correctly.  The patch below checks if ifup is avaiable, and if not
> starts the Gentoo networking scripts.
> 
> This new version includes shell functions where distro specific options
> may be handled (per Ian's suggestion).  

Doing this all in the same script feels like it's going to spiral out of
control into spaghetti-land kind of quickly and also not allow for some
of the real variation that's going to be desired for different
distributions.

Why try to do a one-size-fits-all instead of having scripts which really
can be made to best fit the distro?  With a more traditional build
process, it would be easy enough to have distro specific scripts dropped
into subdirs of the examples directory and use them as
overrides/replacements.  The thing that makes that tricky for Xen is the
way make dist works.  

Thinking aloud -- maybe just setting a variable so we know we're in the
'make dist' case and using that to install all the distro specific stuff
into DESTDIR and then letting install.sh also pick out the right distro
would work.  Then for the more normal install case, just the proper
things for the distro would get installed.  Does this seem reasonable?
I'll try to cook up something today

Jeremy


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel