Re: [Xen-tools] [PATCH] Clean up dom_get() usage

[Christian Limpach <christian.limpach@xxxxxxxxx>]

On 9/15/05, Dan Smith <danms@xxxxxxxxxx> wrote:

The 1st hunk adds a random empty line, please avoid hunks like that in
the future.

> This patch adds sanity checks everywhere dom_get() is used.

I don't think the 3rd hunk is needed.  It would make more sense to
have a patch which replaces the magic dom0 domid by a global variable
indicating the domid of the domain where xend is running.

> In the case of XendDomainInfo.update(), if we get None back from
> dom_get(), we destroy ourselves.  I believe that this should be the
> desired behavior, but arguments to the contrary are welcome.

It's possibly a sensible behaviour, but I'd like to move away from
code which does stuff as a side effect.  We don't want to end up with
countless places doing random actions just because they happen to
notice a state change first.

     christian

_______________________________________________
Xen-tools mailing list
Xen-tools@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-tools