[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH][VT] Clear the pending interrupt on sharedpage when PIC initialized


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
  • From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
  • Date: Wed, 14 Sep 2005 18:03:48 +0800
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 14 Sep 2005 10:01:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcW4P5+STvRQBQ7HQSiY5foRhvquvgA06z2w
  • Thread-topic: [Xen-devel] [PATCH][VT] Clear the pending interrupt on sharedpage when PIC initialized

Keir Fraser wrote:
> On 13 Sep 2005, at 03:40, Jiang, Yunhong wrote:
> 
>> 1) I think the  cpu_reset_interrupt() is a common API on qemu for
>> hardware interrupt/exception etc,while clear the shared page is just
>> for hardware interrupt. Of course, this function is currently used
>> just for hardware interrupt since qemu works as a device model :)
>> But change here may cause following code on cpu_reset_interrupt().
>>      if ( mask == CPU_INTERRUPT_HARD)
>>           ......clear the shared page...
> 
> Hmm... okay, I see your point here. This would be a bit ugly.
> 
> I think placing your  patch under pic_reset() is a better plan.
> 
>   -- Keir

Attached is the changed patch. Please have a look on it.

Thanks
Yunhong Jiang

> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Attachment: irq_base.diff
Description: irq_base.diff

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.