Re: [Xen-devel] [PATCH] Tidy up installation paths

[Anthony Liguori <aliguori@xxxxxxxxxx>]

On Thu, 2005-09-08 at 13:43 -0700, Josh Triplett wrote:
> Why does this patch move xentop?  Unlike several of the binaries being
> moved by this patch (helper binaries and daemons), xentop is intended to
> be directly executed by a user, and should be in a directory expected to
> be in $PATH.  The relevant sections of the patch are:

The purpose of the cleanup is to avoid cluttering $PATH with things that
are executable in another way.  Since xentop is executable via xm top,
this redundancy seemed unnecessary.

It's up to Ian or Christian.  I can go either way.

> 1) Please don't just change the value of the "sbindir" variable in the
> makefile; those variables are intended to mirror the naming structure of
> autotools' destination directory variables, so the variable should be
> renamed to libexecdir. Despite the name, libexecdir is typically set to
> a package-specific directory under /usr/lib/ , on systems which don't
> use libexec directories (meaning pretty much anything other than GNU/Hurd).

We're not following the standard GNUisms.  One thing that is really
needed is more commonality between the tools build files.  I'm sure a
patch to cleanup all of the tools Makefiles would be appreciated.

> 2) The "xm top" interface needs to be changed to pass through command
> line arguments, while somehow avoiding the fact that "xm top --help"
> would refer to itself as "xentop".  (I planned to do this anyway, but if
> you're going to move xentop, then this needs to be done first to avoid
> losing functionality.

The first round of the patch is strictly changing install paths.
Smaller patches are easier to review.  Feel free to submit additional
patches to enhance the xm top interface though.

Regards,

Anthony Liguori

> - Josh Triplett


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel