RE: [Xen-devel] [PATCH] get xenstore buffer in vmx guest

[Rusty Russell <rusty@xxxxxxxxxxxxxxx>]

On Mon, 2005-09-05 at 22:22 +0800, Ling, Xiaofeng wrote:
> Rusty Russell <mailto:rusty@xxxxxxxxxxxxxxx> wrote:
> > Just a minor thing: I'd really prefer an inline function called
> > xenstore_page_virt() or something, rather than a macro which looks
> > like a constant. 
> ok, so the new patch will be:

> --- a/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_comms.h    Tue Aug 30 
> 20:36:49 2005
> +++ b/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_comms.h    Mon Sep  5 
> 22:15:45 2005
> @@ -38,4 +38,17 @@
>  int xs_input_avail(void);
>  extern wait_queue_head_t xb_waitq;
> 
> +#ifdef CONFIG_XEN
> +static inline void *xenstore_page_virt(void)
> +{
> +    return (void*)mfn_to_virt(xen_start_info.store_mfn);
> +}

Great!   I think the (void*) cast is redundant though?

> -postcore_initcall(xenbus_probe_init);
> +module_init(xenbus_probe_init);
> +MODULE_LICENSE("GPL");

This should probably be:
        MODULE_LICENSE("Dual BSD/GPL");

Cheers,
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel