Re: [Xen-devel] [Patch] by default don't give all memory to dom0

[David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>]

Siddha, Suresh B wrote:
> On Thu, Aug 18, 2005 at 08:50:57PM +0100, David Hopwood wrote:
> > Siddha, Suresh B wrote:
> > [...]
> >
> > > +static void parse_reserve_dmamem(char *s)
> > > +{
> > > +    unsigned long long bytes = parse_size_and_unit(s);
> > > +    /* If no unit is specified we default to kB units, not bytes. */
> > > +    if ( isdigit(s[strlen(s)-1]) )
> > > +        reserve_dmapages = (unsigned int)bytes >> (PAGE_SHIFT - 10);
> > > +    else
> > > +        reserve_dmapages = (unsigned int)(bytes >> PAGE_SHIFT);
> > > +}
> > Shouldn't the default unit be consistent for all Xen memory parameters?
> I am just following the dom0_mem conventions for which default unit is kB.
> Am I missing something?
If Kbytes is to be the default unit, then that default should probably be
encoded in 'parse_size_and_unit', rather than having code like the above
convert from bytes to Kbytes in many places.

--
David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel