[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] [x86_64] Fixing PGT_va_mutable and PGT_va_unknown


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
  • From: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
  • Date: Mon, 15 Aug 2005 00:50:34 -0700
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 15 Aug 2005 07:49:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcWhbNaWYUKcPEmER9ut32NT+AeXjwAAOahA
  • Thread-topic: [Xen-devel] [PATCH] [x86_64] Fixing PGT_va_mutable and PGT_va_unknown

Keir Fraser wrote:
> On 15 Aug 2005, at 08:11, Nakajima, Jun wrote:
> 
>> This patch ensures that type_info is always greater than
>> PGT_va_unknown if PGT_va_mutable is set.
> 
> Okay, but I see no reason to change PGT_va_mask. You already include
> 28 bits where you actually need only 27 bits of backptr.

The current one
#define PGT_va_mask         ((unsigned long)((1U<<28)-1)<<PGT_va_shift)
includes only 27 bits (see -1). 

> 
>   -- Keir


Jun
---
Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.