Re: [Xen-devel] [patch] pae: tlbflush linear page table updates

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 9 Aug 2005, at 08:54, Gerd Knorr wrote:

> Yes.  PAE xenlinux (UP) didn't boot up.  The first
> make_page_readonly() faults because the first copy_from_user()
> in ptwr_do_page_fault() fails (which dereferences stuff using
> the linear page table ...).
>
> I hoped the tlbflush also fixes the SMP issues, but it doesn't,
> so there are more bugs.  I'm not sure the PAE/SMP crashes are
> ptwr related, they also happen (although a bit less likely it
> seems) without writable page tables.
Out of interest, can you please try moving the flush_tlb_all() into 
mod_l3_entry(), at the following place:
        if ( unlikely(!UPDATE_ENTRY(l3, pl3e, ol3e, nl3e)) )
        {
            BUG_ON(!create_pae_xen_mappings(pl3e));
            flush_tlb_all(); /* <------- moved to here */
            put_page_from_l3e(nl3e, pfn);
            return 0;
        }

Hopefully that will work just as well.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel