Re: [Xen-devel] [PATCH] alloc_{start,end} truncation

[Gerd Knorr <kraxel@xxxxxxx>]

"Scott Parish" <srparish@xxxxxxxxxx> writes:

> Alloc_{start,end} should be physaddr_t. See attached patch.

Ha, *that* the bug I was hunting as well ;)

> +++ new-xen-pae/xen/arch/x86/domain_build.c   2005-08-05 17:48:07.000000000 
> +0000

This change looks perfectly fine.

> --- old-xen-pae/xen/include/asm-x86/io.h      2005-07-19 18:51:39.000000000 
> +0000
> +++ new-xen-pae/xen/include/asm-x86/io.h      2005-08-05 17:45:17.000000000 
> +0000
> @@ -45,7 +45,7 @@ static inline void * phys_to_virt(unsign
>  /*
>   * Change "struct pfn_info" to physical address.
>   */
> -#ifdef CONFIG_HIGHMEM64G
> +#ifdef CONFIG_TARGET_X86_PAE

That one should be "CONFIG_X86_PAE"

>  #define page_to_phys(page)  ((u64)(page - frame_table) << PAGE_SHIFT)

But I think even better is to simply drop the ifdef and turn that into

"#define page_to_phys(page)  ((physaddr_t)(page - frame_table) << PAGE_SHIFT)"

With these changes in place the dom0 builder survives on my 6GB test
box, now the linux kernel seems to crash early at boot, continuing
debugging ...

  Gerd

-- 
panic("it works"); /* avoid being flooded with debug messages */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel