Re: [Xen-devel] Breakage in -unstable for Transmeta -- Solution

["Carl Holtje ;021;vcsg6;" <cwh0803@xxxxxxxxxx>]

Keir-

In xen/include/asm/page.h, revision 1.53 changed a line from:
  #define PAGE_MASK           (~(PAGE_SIZE-1))
to:
  #define PAGE_MASK           (~(intpte_t)(PAGE_SIZE-1))
and caused Bad Things for Transmeta..

Which leads me to my next question...

It seems to me, and please correct me if I'm wrong, the Best Way to fix
this is with something like a #ifndef CONFIG_X86_TRANSMETA {ver 1.53 code}
#else {earlier code} #endif around this. This is what I've done for my other
changes, and seems to work pretty well. So.. where would
CONFIG_X86_TRANSMETA get defined? I've currently got it in xen/Rules.mk as
"CFLAGS += -DCONFIG_X86_TRANSMETA", and am sure it's not the Right Way to
do it..

Thanks!

(Transmeta patch coming RSN.. I'm sure everybody is salivating for it, so
I'll try to keep the wait short... :) )

Carl

- --

"There are 10 types of people in the world: Those who understand binary
and those that don't."


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel