RE: [Xen-devel] [patch] fix serial locking

["Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>]

> Hi Keir, I'm having trouble with the serial locking patch 
> from a couple weeks ago, specifically serial_getc():
>             spin_lock_irqsave(&port->lock, flags);
>             ...
>             if ( port->driver->getc(port, &c) )
>                 break;
> 
>             spin_unlock_irqrestore(&port->lock, flags);
> 
> That leaves port->lock locked, as soon as the first char is 
> successfully received. This patch fixes it for me:

> Should I take this to mean that almost nobody uses serial console?

Thanks for the patch. Most of us use serial console for debugging, but
apparently only for output...

Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel