Re: [Xen-devel] [PATCH] xs.h and xs_lib.h

[Rusty Russell <rusty@xxxxxxxxxxxxxxx>]

On Fri, 2005-06-10 at 03:32 -0500, aq wrote:
> This patch moves declaration of xs_handle from xs.c to xs.h.

No; why do this?  It's opaque for a reason.  Originally it was just an
int, but Keir insisted it be an opaque structure.  Exposing it binds us
to the current structure again.

> Besides,
> it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile
> uninstalled them when cleaning up.

xs_lib.h should not be installed in /usr/include!

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel