Re: [Xen-devel] [PATCH] make domu_debug run-time option + fix int3 handling for MP

[Kip Macy <kmacy@xxxxxxxxxx>]

"domu_debug" was mutually exclusive with crash_debug, which doesn't make sense
to me. The other stub already had a #if 0 as a pre-processor guard around it. So
the end effect with the patch is that domu_debug would be on by default and cdb
could be enabled at compile-time. As I recall, there is no working functionality
that this changes.  I'll go back and look and recant if I am in error.

I will make debugger_trap_entry call my code only if the domain flag is set, but
right now this is the only debugger type that has a real debugger_trap_entry -
so multiplexing seems a bit silly.  There are hundreds of other places in the
code where we could generalize for future extensibility.



                                -Kip



> 
> Looks allright -- except that the debugger.h changes break the
> non-domu_debug usages.  Even if you fix that, I'm not sure we want
> debugger_trap_entry to be domu_debug only.  Could you please explain
> what the intent is and resend as separate patches?
> Maybe a debug_trap_entry wrapper which tests the DOMF_debug flag and
> either calls the domu_debug function or the other debugger function
> would be better?  Please also leave the #if/#elif construct for easy
> switching between the different debugger stubs...
> 
>      christian
> 

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel